Convert selectors to MWC #11543
Merged
Convert selectors to MWC #11543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
added
the
needs design preview
balloob
reviewed
Feb 5, 2022
| .value=${this.value} | ||
| .disabled=${this.disabled} | ||
| @closed=${stopPropagation} | ||
| @selected=${this._valueChanged} |
There was a problem hiding this comment.
This doesn't seem to work
https://61fdc4fbb19bda3949bd6fca--home-assistant-gallery.netlify.app/#automation/selectors
It works currently
balloob
reviewed
Feb 5, 2022
| @@ -36,27 +36,23 @@ export class HaNumberSelector extends LitElement { | |||
| > | |||
| </ha-slider>` | |||
| : ""} | |||
| <paper-input | |||
| <mwc-textfield | |||
There was a problem hiding this comment.
Not new in this PR, but can we do something about the width of slider vs input?
There was a problem hiding this comment.
Not seeing that?
Firefox only?
balloob
previously approved these changes
Feb 5, 2022
balloob
approved these changes
Feb 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Converts selectors from
papertomwcelement.Next step:
Convert the underlying elements.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: